DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=35703>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=35703 ------- Additional Comments From [EMAIL PROTECTED] 2006-02-19 19:20 ------- (In reply to comment #17) > I appreciate that you've taken the trouble to do the patch and provide a > sample webapp, but I am still against your proposal. No problem, glad to bring my 2 cents, especially for something that I believe is worth it. > As I said in comment #5 IMO these tiles "util" classes should not call the > RequestProcessor. Remember that comment #5 was regarding putting the fix in TilesUtil which was wrong - I agreed with that. And this was fixed in a second release of the patch (see comment #6). > Also as I said in comment #5 you can override the tiles util implementation > used to provide your own custom processing to resolve this. It just won't work because of a broken link in current Tiles/Struts integration. This is documented in Test Phase 1 in comment #16. TilesRequestProcessor would need to be patched (first part of the proposed patch) for that to work. Re-assuming it in a few words: take a Struts web application using a custom RequestProcessor which overrides doInclude() and bring Tiles into it. Then, your implementation of doInclude() will never get called any more for any of your tiles. Is that ok with you ? Well it isn't with me. > I still think we should close this as WONTFIX. Sorry for being such a pain keeping on insisting on that one, but since this is a blocking issue in current Tiles/Struts integration WONTFIX isn't an answer. If we come up with a better solution than the proposed patch that's fine for me. But in any case we do need to come up with a proper solution and I'm not giving up until we do. Tx Patrick P.S.: to be honest I still don't understand why you don't like the idea of putting the fix in TilesUtilStrutsImpl and TilesUtilStrutsModuleImpl as a default behaviour, everyone being free to change this default behaviour by overriding these classes, rather than forcing everyone to implement something to get this to work! The above 2 classes are already there to make the glue between Tiles and Struts, as a default implementation, so I don't see the point of not using them for what they were originally meant for (again look at the Javadoc comments in TilesUtilStrutsModuleImpl). -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
