>From: "Craig McClanahan" <[EMAIL PROTECTED]> > > On 4/11/06, Gary VanMatre wrote: > > > > >It looks like the changes for the validator broke the core-library unit > > >tests. Gary, can you take a look please? > > >[EMAIL PROTECTED] core-library]$ ant test > > >Buildfile: build.xml > > > > > > > We are now locked into validator 1.3. I think you need to run the > > download-dependencies. I changed the ant and maven builds to > > pull the correct version. > > > Yep ... that fixed it. > > Could you do me a favor (and if you did and I missed it, sorry!!! :-), and > make an explicit note on the checkin message when an update to the > dependencies is needed? >
Sure, I should have made that more clear. I just stated that we added support for 1.3 and not that it breaks if you don't use it. http://issues.apache.org/bugzilla/show_bug.cgi?id=39121 > Craig > Gary > > It it's working for me but if that doesn't work, I probably need > > to delete my snapshot (must have missed something on the checkin). > > > > > > > > > [junit] Testcase: testRequired took 0.81 sec > > > [junit] Testcase: testCustom took 0.218 sec > > > [junit] Testcase: testValidateRequired took 0.256 sec > > > [junit] FAILED > > > [junit] Not Found: function jcv_retrieveFormName(form) > > > [junit] junit.framework.AssertionFailedError: Not Found: function > > >jcv_retrieveFormName(form) > > > [junit] at > > >org.apache.shale.validator.CommonsValidatorTestCase.checkScript( > > >CommonsValidatorTestCase.java:1110) > > > [junit] at > > >org.apache.shale.validator.CommonsValidatorTestCase.testValidateRequired( > > >CommonsValidatorTestCase.java:251) > > > > The javascript is pulled for the commons-validator jar now. > > > > > > >BUILD FAILED > > >/home/craigmcc/Apache/struts/current/shale/core-library/build.xml:559: > > Test > > >org.apache.shale.validator.CommonsValidatorTestCase failed > > >
