Oh yeah, hidden in that last commit... Since I was changing the Controller interface anyway, I went ahead and got rid of the perform () method. It was deprecated and needed to go away eventually. Please let me know if anyone has serious issues with that.

Greg

On Apr 28, 2006, at 3:03 PM, Greg Reddin wrote:

I've added a preliminary version of a TilesContext interface and refactored the core API to use it. The interface is a first attempt at extracting the Servlet API dependencies. Here are some more details:

I debated about whether to model TilesContext after Commons-Chain's WebContext or JSF's ExternalContext. WebContext seemed a bit more applicable so I started with a very similar interface. I then added a few more methods mostly modeled after ExternalContext. I created a factory and a Servlet-based implementation just to get the tests to pass. I suspect the factory and the way it's being used to change significantly after I look further at the way Faces and Chain use their context classes in various environments. Note that I ran out of time before I had a chance to look at these other examples, so if you look at what I just committed and inherently see a better way, please share.

I have not tested this at all other than the provided unit tests, so it probably doesn't work :-) I'm just trying to push something through before I have to take off for the weekend so some progress is being made. I'd love it if some others would look at my most recent commit and give me some advice on how to improve it. Starting next week I hope to be able to flesh this all out further.

This is the last refactoring step that is needed before the Standalone Tiles API will be stable. Yippeeeee! If I don't respond to any emails for a while it's because I'm going out of town for the weekend, but I'll check back in on Monday.

Greg

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to