I'm cool with that. Sticking with verbs, there's also err(), warn(),
inform(). ;)

Bob

On 5/5/06, Jason Carreira <[EMAIL PROTECTED]> wrote:
Yeah, I generally like it, but I still prefer the more obvious addError(), 
addWarning(). I like my methods as verbs... makes reading the code easier (to 
me).

> - The attached version supports arbitrary levels. I
> used an interface
> instead of an enum so the user can define additional
> levels if they
> wish. Should Level extend Comparable?
>
> - It has built in support for INFO, WARN, and ERROR
> along with
> respective convenience methods.
>
> - It provides a Map of field messages. It's not
> necessary for Messages
> itself to implement both Map and List. Delegating to
> separate objects
> is less confusing.
>
> - Adding messages and checking for the presence of
> messages
> (hasErrors()) should be dead simple. Getting the
> messages doesn't have
> to be as convenient (at least not through the
> published API).
>
> - "Request-scoped" is the wrong word. We're really
> talking about "not
> associated with a field." Page-scoped? Form-scoped?
> Global?
>
> Thanks,
> Bob
> ------------------------------------------------------
> ---------------
> To unsubscribe, e-mail:
> [EMAIL PROTECTED]
> For additional commands, e-mail:
> [EMAIL PROTECTED]
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=29554&messageID=57361#57361


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to