On 6/20/06, Frank W. Zammetti <[EMAIL PROTECTED]> wrote:
So, I'm looking through the Checkstyle results for all SAF1 subprojects to see if there is anything else that can and maybe should be addressed by rule changes... one particular complaint that shows up an awful lot is the "Line has trailing spaces" complaint. My own opinion is that all the source files should have trailing spaces removed (which is a trivial task in UltraEdit, I could do every source file in all subprojects in about 5 minutes). But, I wanted to throw it out there for discussion because if that rule is disabled, the complaint numbers go down quite a bit immediately :) Along those lines is the "File does not end with a newline" complaint. Again, my own opinion is to add the space to all files (only slightly harder, might take me 15 minutes). But, disabling the rule is an option as well. So, what does everyone think? Are these two "issues" something we think could just as well be ignored, and therefore the rules turned off?
I'm with you - I'd prefer to fix them, rather than ignore them. -- Martin Cooper FYI, just some quick stats, after the latest rule changes (I'll save
everyone the trouble of doing it themselves!): Core .................. 1113 Taglib ................ 921 Apps - Cookbook ....... 208 Tiles ................. 2447 Faces ................. 682 Faces Example 1 ....... 556 Faces Example 2 ....... 548 Extras ................ 22 Examples .............. 514 Mailreader DAO ........ 136 Mailreader ............ 36 EL .................... 2546 Struts EL Exercise .... 123 Scripting ............. 4 Scripting Mailreader .. 6 Frank --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
