On 10/4/06, Martin Cooper <[EMAIL PROTECTED]> wrote:
On 10/4/06, Antonio Petrelli <[EMAIL PROTECTED]> wrote:
>
> Re-hi list :-)
>
> I noticed that GetTag extends InsertTag and it does not add anything, it
> only sets "isErrorIgnored" flag to true.
> So I am thinking on removing one of those.
> From my POV it should be better to remove InsertTag (or better, remove
> GetTag then rename InsertTag to GetTag), because this way it is clear
> that GetTag is the opposite of PutTag.
> What do you think?
I may get some of the details wrong here, but hopefully someone (hi Ted!)
can correct me if I do...
A long time ago, in the dim and distant past, Struts had the 'template'
taglib. Then Tiles came along, and we eventually integrated it in such a way
that it was backwards compatible with the 'template' taglib. That is, Tiles
became part of Struts, and was modified in such a way that it incorporated
all of the functionality of the 'template' taglib. We could then remove the
original 'template' taglib.
I believe that 'get' was originally from the 'template' taglib, and 'insert'
came from Tiles and did essentially the same thing, making 'insert" the
"real" Tiles tag. It would be good if there was some way we could know which
tag most people use with Tiles today, but I doubt that's possible. That
being the case, I don't have an opinion on which one to keep and which one
to drop.
Not so simple the template taglib had both get and insert :-)
http://struts.apache.org/1.0.2/api/org/apache/struts/taglib/template/package-summary.html
But you're correct "insert" is the tiles way of doing things as the
comments in the GetTag source indicate that it is there only for
compatibility with the template taglib. So on that basis it should be
the GetTag that goes - but I like Antonio's argument of "get being the
opposite of put". If the decision is to have get as the standard then
I would argue to keep insert for backwards compatibility.
Niall
P.S. I use insert, rather than get
--
Martin Cooper
Ciao
> Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
