Don Brown wrote:
David H. DeWolf wrote:
The first thing I noticed in this example is that there appears to be a missing configuration section. Is it safe to assume that in order to achieve extensibility you're thinking that selectors would be configured something like:

<result-selector name="html,html-partial,json,xml" class="o.a.s.dispatcher.ContentTypeResultSelector/>

Well, I was wondering if you wouldn't even need this... Perhaps the possible token list would just be documented in the javadocs of the selector and in the user guide. You could specify the chain of selectors in struts.properties, and then, it would only be a comma-delimited list of class names.

Gotcha, to some extent :)

By using the chain, all selectors have the opportunity to participate and thus (since they are passed the entire list of matching results) don't need to have the condition explicitly configured. Makes great sense, thanks for the clarification.

That said, didn't I read somewhere that we're moving towards getting rid of struts.properties? Wouldn't it be easier and more consistent to just add the following to struts.xml:

<result-selector class="o.a.s.dispatcher.ContentTypeResultSelector"/>

Seems to me like this type of configuration is very similar to the interceptor configuration and should be designed similarly.

David



Don


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to