Follow-up for the described issues:
Annotation driven action configuration issue - WW-1695
PrincipalAware issue - WW-1696

Don Brown schrieb:
I believe we currently have portlet support as "experimental", so it shouldn't affect the quality vote.


Regarding this along with Ted's remark to fix release notes for 2.0.4 to declare portlet support as experimental, I change my vote to
[ ] Leave at test build
[ ] Alpha
[x] Beta
[ ] General Availability (GA)

- Rene

Don

Rene Gielen wrote:
Hey guys,

a few minutes ago I came to the opinion that we have some major issues with portlet integration, which imo should be fixed before rolling out current build:

- Annotation based configuration for actions seems to fail at least in my portlet environment (Liferay 4.2.1), resulting in infinite loop while scanning for action classes in configured packages. Had no time to dig deeper yet, but the issue is reproducible. I'll file an issue.

- ServletConfigInterceptor, along with PrincipalAware / PrincipalProxy are not portlet aware. The implementation relies on access to HttpServletRequest, but the Jsr168Dispatcher fails to put the HttpServletRequest into action context (in fact there is a TODO in the code!?!). The other (better: additional) option would be to make PrincipalProxy HttpServletRequest independent, to deliver Principal related information from PorletRequest, if applicable. We should really consider this a major issue, preventing us from considering portlet intergration (and therefore core) "ready for public". I'll file an issue on that, too.

For that reason, currently my vote is:
>    [x] Leave at test build
>    [ ] Alpha
>    [ ] Beta
>    [ ] General Availability (GA)

- Rene



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



--
Rene Gielen  | http://it-neering.net/
Aachen       | PGP-ID: BECB785A
Germany      | gielen at it-neering.net

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to