On Fri, 2008-01-18 at 14:50 +0000, Al Sutton wrote: > Thanks for the pointer, but I've already created patches. > > I think Ted wants someone to help merge them in which is why I'm looking for > some docs (that is unless Ted says "Sure... throw me some more patches" :)). > > Al. >
I wouldn't mind helping merge patches, but I don't think I've earned enough karma yet. Most of the patches I've submitted need a bit of finesse before being applied. Don mentioned to me once that there is a nifty code-review tool that can be added on to bamboo (IIRC). Would it be workable to add some sort of intermediary step so that a patch can get approved by some of the more experienced committers like Ted, Don or Musachy and then someone else can apply the patch and run unit tests, etc? For instance, if someone takes a quick look at a patch and says - "well that makes sense, if all the unit tests pass with that patch applied, then we should use it." Then someone else with the time to do the work could go ahead and take care of it. The opposite of that example would also be helpful. So if someone looks at it and suggests some revisions, such as a patch I posted that Don gave me some tips on - "Add a unit test, and get X object through DI." Like a "pass with revisions" score on a code review, it will give a "worker bee" style committer some idea of how to push it forward. -Wes --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
