On Wed, 2008-03-05 at 11:34 -0800, Chris Pratt wrote:
> On Wed, Mar 5, 2008 at 11:13 AM, Antonio Petrelli
> <[EMAIL PROTECTED]> wrote:
> > Hi all,
> > I've seen that Struts 2 (along with XWork code) do not use generics
> > "completely".
> > I see too many maps and lists without type. I think they should be
> > corrected, we use Java 5 and generics are probably the best feature of
> > it.
> >
>
> I know I'm not a committer and my vote doesn't count but I'm going to
> give it anyway =9^)
>
> +100
>
> (*Chris*)
>
Go ahead and start a JIRA, I would suggest working on a patch to go
along with it... I know when I'm using eclipse, it complains about
these. It would be nice to see the whole codebase listed w/o compiler
warnings. If you are going to parameterize the collections that are
used, you will find that not all of them can be parameterized (such as
the Map that represents the HTTP session), but you can Annotate them
with @SuppressWarnings("unchecked") (or whichever annotation it is).
This we could clear up what we expect to be a truly generic collection
and one that should be type-checked. This wouldn't be considered a
high-priority issue, but I doubt that anyone would object to you working
on it ;)
-Wes
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
