I am sorry, I was to excited about the JUEL plugin and totally forgot about it. If you have additional changes, create a new patch and I will merge that one.
musachy On Fri, Nov 6, 2009 at 9:40 AM, Christian Stone <xt...@stonescape.net> wrote: > I was wondering if you had a chance to commit the patch I submitted with > this bug [WW-3291]. I did more work in the project with another issue > (using freemarker and velocity templates interchangeably as decorators with > the same *full* value stack) and wish to push that. Since both bugs take > place in the same codebase, I am wondering if I should just send you a > single patch for both, or wait until the one is closed before creating a > patch for the other issue. > > On a side note, I moved the changes I made into several production clients. > I have websites with more than a dozen decorators and hundreds of view > files. I am _finally_ able to start the migration to Freemarker from > Velocity that I wasn't able to do before. I converted 4 of the files to > Freemarker without having the overhead of needing to convert all of them in > one sitting. It is glorious. Also, I am able to access all the statics and > whatnot that I couldn't before, so using static keys is a huge blessing for > readability. Also, the enhanced error reporting has already helped me > several times diagnose issues on the server. > > Anyways, congrats on the work you just accomplished. Two of the biggest > complaints on Struts 2 are speed and error reporting. Any steps to mitigate > either of these issues is a huge win! > > -- Christian Stone > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org > For additional commands, e-mail: dev-h...@struts.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
