And there is still place for improvement, take a look at the
ComponentTagSupport#doStartTag, each time instance of Container is
taken from Dispatcher, which means each time configuration is checked
if needs to be reloaded - obviously it doesn't make sense to check
that or reload configuration during each tag execution. Configuration
should checked/reloaded on the beginning of request and stay constant
till the end of request.

So I think it is better to put Configuration into HttpServletRequest
(or wrapped one) and used it inside tags instead of using
Dispatcher.getInstance().getContainer().


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Reply via email to