Every <s:text> will scan up the package hierarchy ie <s:text name="eventedit.subtitle" /> is does these getMessage(..) findText(..) calls:
ListEvents.title : org.events.ui.struts2.editor.Events ListEvents.title : org.events.ui.struts2.editor.EventBase ListEvents.title : org.events.ui.struts2.util.ActionBase ListEvents.title : com.opensymphony.xwork2.ActionSupport ListEvents.title : java.lang.Object org.events.ui.struts2.editor.package : ListEvents.title org.events.ui.struts2.package : ListEvents.title org.events.ui.package : ListEvents.title org.events.package : ListEvents.title org.package : ListEvents.title org.events.ui.struts2.editor.package : ListEvents.title org.events.ui.struts2.package : ListEvents.title org.events.ui.package : ListEvents.title org.events.package : ListEvents.title org.package : ListEvents.title org.events.ui.struts2.util.package : ListEvents.title org.events.ui.struts2.package : ListEvents.title org.events.ui.package : ListEvents.title org.events.package : ListEvents.title org.package : ListEvents.title com.opensymphony.xwork2.package : ListEvents.title com.opensymphony.package : ListEvents.title com.package : ListEvents.title I did look at using TextProviderSupport in the config, but I think it would involve duplicating the LocalizedTextUtil class with my local mods. <bean type="com.opensymphony.xwork2.TextProvider" name="myTextProvider" class="local.TextProviderSupport" scope="default" /> <constant name="struts.xworkTextProvider" value="myTextProvider"/> On 6 March 2014 12:43, Dave Newton <davelnew...@gmail.com> wrote: > What's the actual speedup? > > It might be nice if it was configurable; I'm not sure what the stats would > be regarding how many apps use S2 vs. "regular" localization. > > Dave > > > > On Thu, Mar 6, 2014 at 7:38 AM, Greg Huber <gregh3...@gmail.com> wrote: > > > Seeing this mod the other day has reminded me that I do a local change on > > LocalizedTextUtil to speed up the screens. > > > > What I do is to add a check to see if the property comes from the > > getDefaultMessage(..) method (ie from ApplicationResources.properties) > and > > if it does skip all the checking that it does (for every request). If > you > > have a lot of inheritance or <s:text> and do not use properties / class > > name strategy it makes the rendering a whole lot faster. > > > > ie > > > > HashSet<String> set = defaultLocationMap.get(locale.toString()); > > if(set != null && set.contains(aTextName)){ > > ... > > } > > > > Would this be acceptable here? > > > > Cheers Greg > > > > > > -- > e: davelnew...@gmail.com > m: 908-380-8699 > s: davelnewton_skype > t: @dave_newton <https://twitter.com/dave_newton> > b: Bucky Bits <http://buckybits.blogspot.com/> > g: davelnewton <https://github.com/davelnewton> > so: Dave Newton <http://stackoverflow.com/users/438992/dave-newton> >