Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114148402
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.opensymphony.xwork2.spring;
+
+import com.opensymphony.xwork2.util.ClassLoaderUtil;
+import org.apache.commons.lang3.reflect.MethodUtils;
+
+import java.lang.reflect.Proxy;
+
+/**
+ * <code>SpringUtils</code>
+ * <p>
+ * Various utility methods dealing with spring framework
+ * </p>
+ *
+ */
+public class SpringUtils {
+ /**
+ * Get the ultimate <em>target</em> object of the supplied {@code
candidate}
+ * object, unwrapping not only a top-level proxy but also any number of
+ * nested proxies.
+ * <p>If the supplied {@code candidate} is a Spring proxy, the
ultimate target of all
+ * nested proxies will be returned; otherwise, the {@code candidate}
+ * will be returned <em>as is</em>.
+ * @param candidate the instance to check (potentially a Spring AOP
proxy;
+ * never {@code null})
+ * @return the target object or the {@code candidate} (never {@code
null})
+ * @throws IllegalStateException if an error occurs while unwrapping a
proxy
+ */
+ public static <T> T getUltimateTargetObject(Object candidate) {
+ try {
+ if (isAopProxy(candidate) &&
+ implementsInterface(candidate.getClass(),
"org.springframework.aop.framework.Advised")) {
+ Object targetSource = MethodUtils.invokeMethod(candidate,
"getTargetSource");
--- End diff --
Hmm... Never used `AopTestUtils`. But `Advised` extends `TargetClassAware`.
Can `getTargetClass` just be invoked instead of two method calls? See
[`AopUtils`](https://github.com/spring-projects/spring-framework/blob/master/spring-aop/src/main/java/org/springframework/aop/support/AopUtils.java).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
