lukaszlenart commented on code in PR #533:
URL: https://github.com/apache/struts/pull/533#discussion_r841388269
##########
pom.xml:
##########
@@ -103,6 +103,20 @@
</organization>
<properties>
+ <currentVersion>${project.version}</currentVersion>
+
<struts2.springPlatformVersion>5.3.18.RELEASE</struts2.springPlatformVersion>
+ <ognl.version>3.1.8</ognl.version>
+ <asm.version>3.3</asm.version>
+ <asm5.version>5.0.2</asm5.version>
+ <tiles.version>3.0.5</tiles.version>
+ <tiles-request.version>1.0.6</tiles-request.version>
+ <log4j2.version>2.5</log4j2.version>
Review Comment:
You have duplicated these properties and some of them have been reverted to
very old versions. Also this changes nothing as the same properties are defined
a few lines below which means they will overwrite your changes - that's why all
the tests have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
