lowc1012 commented on a change in pull request #174: SUBMARINE-202. submarine core need to support MXNet URL: https://github.com/apache/submarine/pull/174#discussion_r377434429
########## File path: submarine-client/src/main/java/org/apache/submarine/client/cli/runjob/RunJobCli.java ########## @@ -219,6 +224,23 @@ private void addTensorboardOptions(Options options) { CAN_BE_USED_WITH_TF_ONLY); } + private void addSchedulerOptions(Options options) { + options.addOption(CliConstants.N_SCHEDULERS, true, + "Number of scheduler tasks of the job. " + + "It should be 1 or 0, by default it's 0."+ + CAN_BE_USED_WITH_MXNET_ONLY); + options.addOption(CliConstants.SCHEDULER_DOCKER_IMAGE, true, + "Specify docker image for scheduler, when this is not specified, " + + "scheduler uses --" + CliConstants.DOCKER_IMAGE + + " as default. " + CAN_BE_USED_WITH_MXNET_ONLY); + options.addOption(CliConstants.SCHEDULER_LAUNCH_CMD, true, + "Commandline of scheduler, arguments will be " + + "directly used to launch the scheduler. " + CAN_BE_USED_WITH_MXNET_ONLY); + options.addOption(CliConstants.SCHEDULER_RES, true, + "Resource of each scheduler, for example " + + "memory-mb=2048,vcores=2,yarn.io/gpu=2. " + CAN_BE_USED_WITH_MXNET_ONLY); Review comment: Thanks for the review! I will remove it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org