[ https://issues.apache.org/jira/browse/SUBMARINE-888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chi-Sheng Liu updated SUBMARINE-888: ------------------------------------ Description: Currently our controller code is a bit messy and have some redundant codes. We need to refactor it. This will be helpful when we start testing our controller in the near future. Todos: # Change module import path from submarine-cloud-v2 to github.com/apache/submarine/submarine-cloud-v2 so that our packages can be viewed on https://pkg.go.dev # Make controller a new package # Delete main_test.go # Remove namespace function arguments when creating resources # Extract all resource creation spec to separate functions # Remove port forward function References: # [https://github.com/kubernetes/sample-controller] # [https://github.com/prometheus-operator/prometheus-operator] # [https://github.com/GoogleCloudPlatform/spark-on-k8s-operator] was: submarine-cloud-v2 code refactor Todos: # Change module import path from submarine-cloud-v2 to github.com/apache/submarine/submarine-cloud-v2 so that our packages can be viewed on https://pkg.go.dev # Make controller a new package # Delete main_test.go # Remove namespace function arguments when creating resources # Extract all resource creation spec to separate functions # Remove port forward function References: # [https://github.com/kubernetes/sample-controller] # [https://github.com/prometheus-operator/prometheus-operator] # [https://github.com/GoogleCloudPlatform/spark-on-k8s-operator] > submarine-cloud-v2 code refactor > -------------------------------- > > Key: SUBMARINE-888 > URL: https://issues.apache.org/jira/browse/SUBMARINE-888 > Project: Apache Submarine > Issue Type: Improvement > Reporter: Chi-Sheng Liu > Assignee: Chi-Sheng Liu > Priority: Major > > Currently our controller code is a bit messy and have some redundant codes. > We need to refactor it. This will be helpful when we start testing our > controller in the near future. > Todos: > # Change module import path from submarine-cloud-v2 to > github.com/apache/submarine/submarine-cloud-v2 so that our packages can be > viewed on https://pkg.go.dev > # Make controller a new package > # Delete main_test.go > # Remove namespace function arguments when creating resources > # Extract all resource creation spec to separate functions > # Remove port forward function > > References: > # [https://github.com/kubernetes/sample-controller] > # [https://github.com/prometheus-operator/prometheus-operator] > # [https://github.com/GoogleCloudPlatform/spark-on-k8s-operator] -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org