This is an automated email from the ASF dual-hosted git repository.
kaihsun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new 031b1c9 SUBMARINE-903. Submarine operator created tensorboard is
inconsistent with helm-charts template
031b1c9 is described below
commit 031b1c9cff1b377e21ca29058525ebef48afad0a
Author: Kenchu123 <[email protected]>
AuthorDate: Mon Jul 5 14:26:48 2021 +0800
SUBMARINE-903. Submarine operator created tensorboard is inconsistent with
helm-charts template
### What is this PR for?
Submarine operator should create tensorboard with settings same as
submarine-tensorboard.yaml, but found different at readinessProbe.
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-903
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
Author: Kenchu123 <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
Closes #646 from Kenchu123/SUBMARINE-903 and squashes the following commits:
3721e090 [Kenchu123] SUBMARINE-903. Add ReadinessProbe config to
submarine-tensorboard
---
submarine-cloud-v2/pkg/controller/submarine_tensorboard.go | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/submarine-cloud-v2/pkg/controller/submarine_tensorboard.go
b/submarine-cloud-v2/pkg/controller/submarine_tensorboard.go
index 4cadc36..f9bfaaf 100644
--- a/submarine-cloud-v2/pkg/controller/submarine_tensorboard.go
+++ b/submarine-cloud-v2/pkg/controller/submarine_tensorboard.go
@@ -139,6 +139,14 @@ func newSubmarineTensorboardDeployment(submarine
*v1alpha1.Submarine) *appsv1.De
SubPath: tensorboardName,
},
},
+ ReadinessProbe:
&corev1.Probe{
+ Handler:
corev1.Handler {
+
TCPSocket: &corev1.TCPSocketAction {
+
Port: intstr.FromInt(6006),
+ },
+ },
+ PeriodSeconds:
10,
+ },
},
},
Volumes: []corev1.Volume{
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
