This is an automated email from the ASF dual-hosted git repository.

pingsutw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new 5088efe  SUBMAEINE-959. Fix error in submarine-k8s test
5088efe is described below

commit 5088efe6ac85eacacc5d576fb44bf517f8d940c0
Author: Lisa <aeioul...@gmail.com>
AuthorDate: Mon Aug 9 16:47:15 2021 +0800

    SUBMAEINE-959. Fix error in submarine-k8s test
    
    ### What is this PR for?
    Set notebook id in the response of 'getNotebook' function to fix the error.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-959
    
    ### How should this be tested?
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Do the license files need updating? No
    * Are there breaking changes for older versions? No
    * Does this need new documentation? No
    
    Author: Lisa <aeioul...@gmail.com>
    
    Signed-off-by: Kevin <pings...@apache.org>
    
    Closes #703 from aeioulisa/SUBMARINE-959 and squashes the following commits:
    
    9399fb94 [Lisa] set notebook id
---
 .../main/java/org/apache/submarine/server/notebook/NotebookManager.java  | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/submarine-server/server-core/src/main/java/org/apache/submarine/server/notebook/NotebookManager.java
 
b/submarine-server/server-core/src/main/java/org/apache/submarine/server/notebook/NotebookManager.java
index b183f5a..3de8151 100644
--- 
a/submarine-server/server-core/src/main/java/org/apache/submarine/server/notebook/NotebookManager.java
+++ 
b/submarine-server/server-core/src/main/java/org/apache/submarine/server/notebook/NotebookManager.java
@@ -157,6 +157,7 @@ public class NotebookManager {
     }
     Notebook foundNotebook = submitter.findNotebook(notebook.getSpec());
     foundNotebook.rebuild(notebook);
+    foundNotebook.setNotebookId(NotebookId.fromString(id));
 
     return foundNotebook;
   }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org
For additional commands, e-mail: dev-h...@submarine.apache.org

Reply via email to