This is an automated email from the ASF dual-hosted git repository.

pingsutw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new 69ff22b  SUBMARINE-1036. Can't import submarine in notebook
69ff22b is described below

commit 69ff22b567db19737ccd9cc5a0c8da89c2c53cc7
Author: jeff-901 <b07901...@ntu.edu.tw>
AuthorDate: Wed Sep 29 15:20:56 2021 +0800

    SUBMARINE-1036. Can't import submarine in notebook
    
    ### What is this PR for?
    Pip install submarine after conda activate. And remove pip install mlflow 
and boto3 in dockerfile, because it is in the dependency of submarine-sdk.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/SUBMARINE-1036
    
    ### How should this be tested?
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Do the license files need updating? No
    * Are there breaking changes for older versions? No
    * Does this need new documentation? No
    
    Author: jeff-901 <b07901...@ntu.edu.tw>
    
    Signed-off-by: Kevin <pings...@apache.org>
    
    Closes #758 from jeff-901/SUBMARINE-1036 and squashes the following commits:
    
    c54388a1 [jeff-901] only update numpy version in notebook
    d1f0cfe9 [jeff-901] fix qlib example dependency
    1d62cea4 [jeff-901] delete redundant space
    1101d714 [jeff-901] fix bug
---
 dev-support/docker-images/jupyter/Dockerfile | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/dev-support/docker-images/jupyter/Dockerfile 
b/dev-support/docker-images/jupyter/Dockerfile
index 644873c..055a48e 100644
--- a/dev-support/docker-images/jupyter/Dockerfile
+++ b/dev-support/docker-images/jupyter/Dockerfile
@@ -94,9 +94,11 @@ RUN wget --quiet 
https://repo.continuum.io/miniconda/Miniconda3-py37_${MINICONDA
     conda clean --all -f -y && \
     rm -rf /home/$NB_USER/.cache/yarn
 
+RUN conda init bash 
 # Install latest sumbarine python sdk and notebook
-RUN git clone https://github.com/apache/submarine && \
-    pip install -e submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
+RUN source ~/.bashrc && conda activate && \
+    git clone https://github.com/apache/submarine && \
+    pip install submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
     conda install nodejs && \
     conda install -c conda-forge jupyterlab jupyterlab-git && \
     jupyter lab build
@@ -106,12 +108,9 @@ RUN cp 
submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipyn
     cp -r 
submarine/submarine-sdk/pysubmarine/example/{data,deepfm_example.ipynb,deepfm.json}
 $HOME && \
     rm submarine -rf
 
-# Install mlflow & minio dependencies
-RUN pip install boto3==1.17.58 mlflow==1.15.0
-
 # Install latest stable qlib
 RUN conda install -c conda-forge cvxpy==1.0.21
-RUN pip install numpy==1.19.5 pyqlib==0.6.2
+RUN pip install numpy=1.20.0 pyqlib==0.6.2
 
 # Add qlib example in notebook
 RUN wget 
https://raw.githubusercontent.com/microsoft/qlib/main/examples/workflow_by_code.ipynb
 -P $HOME

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org
For additional commands, e-mail: dev-h...@submarine.apache.org

Reply via email to