This is an automated email from the ASF dual-hosted git repository.
pingsutw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new 726587c2 SUBMARINE-1235. Display test coverage in PR check progress
726587c2 is described below
commit 726587c22dc13970ea354fc0c92530de57ae1c77
Author: JackLiu00521 <[email protected]>
AuthorDate: Mon May 2 22:00:55 2022 +0800
SUBMARINE-1235. Display test coverage in PR check progress
### What is this PR for?
Display test coverage in PR check progress
### What type of PR is it?
Feature
### Todos
- [x] Check code coverage report can be updated to SonaCloud
- [x] Add CodeCov PR comment in every PR
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1235
### How should this be tested?
Setup both github and codecov, the PR comment should appear everytime while
PR
### Screenshots (if appropriate)
<img width="974" alt="image"
src="https://user-images.githubusercontent.com/12693623/165059975-63d6f529-ad34-4a78-af8d-cc65fcbadd5e.png";>
Test screenshot in my own repository
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
Author: JackLiu00521 <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Closes #943 from JackLiu00521/SUBMARINE-1235 and squashes the following
commits:
9e27b805 [JackLiu00521] SUBMARINE-1235. change sonarcloud and codecov run
occasion
fa171144 [JackLiu00521] SUBMARINE-1235. resolve conflict
41272aa8 [JackLiu00521] resolve conflict
3c1204f7 [JackLiu00521] SUBMARINE-1235. resolve conflic
311cccf0 [JackLiu00521] fix indentation
3e9504ef [JackLiu00521] SUBMARINE-1235. delete testCodeCov job
f244f401 [JackLiu00521] SUBMARINE-1235. update master.yml
96ed516f [JackLiu00521] SUBMARINE-1235. update master.yml
3fed2108 [JackLiu00521] SUBMARINE-1235. delete JDK11 install in testCodecov
b6eb055d [JackLiu00521] SUBMARINE-1235. edit codecov action
89a30424 [JackLiu00521] SUBMARINE-1235. add seperate Codecov test in Action
7988c44e [JackLiu00521] SUBMARINE-1235. add Codecov
---
.github/workflows/master.yml | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml
index a2d65982..a37f1815 100644
--- a/.github/workflows/master.yml
+++ b/.github/workflows/master.yml
@@ -556,9 +556,8 @@ jobs:
run: |
yarn add prettier@^2.6.2
yarn checkformat
- sonarcloud:
- if: github.repository == 'apache/submarine' && github.event_name == 'push'
&& github.ref == 'refs/heads/master'
- name: SonarCloud
+ sonarcloud-and-codecov:
+ name: SonarCloud and Codecov
runs-on: ubuntu-latest
needs:
- submarine-e2e
@@ -642,10 +641,15 @@ jobs:
- name: Calculate combined coverage
run: ./dev-support/cicd/coverage.sh
- name: Build and analyze with JDK 11 # sonar-maven-plugin only support
JDK 11
+ if: github.repository == 'apache/submarine' && github.event_name ==
'push' && github.ref == 'refs/heads/master'
run: mvn -B verify -DskipTests
org.sonarsource.scanner.maven:sonar-maven-plugin:sonar
-Dsonar.host.url=https://sonarcloud.io -Dsonar.organization=apache
-Dsonar.projectKey=apache_submarine
env:
SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ - name: Upload coverage report to Codecov
+ uses: codecov/codecov-action@v2
+ with:
+ files: ./target/coverage/all.xml
- name: Delete temporary build artifacts before caching
run: |
#Never cache local artifacts
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/12693623/165059975-63d6f529-ad34-4a78-af8d-cc65fcbadd5e.png"](https://user-images.githubusercontent.com/12693623/165059975-63d6f529-ad34-4a78-af8d-cc65fcbadd5e.png"){kind=link}