This is an automated email from the ASF dual-hosted git repository.

kuanhsun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new 6a7b5fe1 SUBMARINE-1270. move surffire configuration to submodule
6a7b5fe1 is described below

commit 6a7b5fe1ef0dfe90386059393adbd8b671f65d7b
Author: FatalLin <fatal...@gmail.com>
AuthorDate: Mon May 9 15:17:06 2022 +0800

    SUBMARINE-1270. move surffire configuration to submodule
    
    ### What is this PR for?
    <!-- A few sentences describing the overall goals of the pull request's 
commits.
    First time? Check out the contributing guide - 
https://submarine.apache.org/contribution/contributions.html
    -->
    refer to https://github.com/apache/submarine/pull/953, I found out the 
surffire didn't work if I only add the configuration in root pom.xml, so I move 
them to submodules.
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    <!-- * Open an issue on Jira 
https://issues.apache.org/jira/browse/SUBMARINE/
    * Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. 
`SUBMARINE-23. PR title`
    -->
    https://issues.apache.org/jira/browse/SUBMARINE-1270
    ### How should this be tested?
    <!--
    * First time? Setup Travis CI as described on 
https://submarine.apache.org/contribution/contributions.html#continuous-integration
    * Strongly recommended: add automated unit tests for any new or changed 
behavior
    * Outline any manual steps to test the PR here.
    -->
    check coverage report.
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Do the license files need updating?No
    * Are there breaking changes for older versions?No
    * Does this need new documentation?No
    
    Author: FatalLin <fatal...@gmail.com>
    
    Signed-off-by: kuanhsun <kuanh...@apache.org>
    
    Closes #954 from FatalLin/SUBMARINE-1270 and squashes the following commits:
    
    8b60db88 [FatalLin] move configruation to submodule
    9e972c00 [FatalLin] Merge branch 'master' of 
https://github.com/apache/submarine into SUBMARINE-1270
    9c8822f9 [FatalLin] move surffire module configuration to submodules
    61365574 [FatalLin] remove debugging message
    6f1b5739 [FatalLin] move surffire setting to root
    ecfb0be9 [FatalLin] update pom
    82442046 [FatalLin] rename test class
    faf75ff0 [FatalLin] align test framework to junit and renmae test class
    f446204c [FatalLin] try
    e11b6080 [FatalLin] fix test name
    be1ea607 [FatalLin] try
    b92f3fc3 [FatalLin] remove unused dependency
    625301e8 [FatalLin] updagte config
    f22cb542 [FatalLin] update config
    d3f63b23 [FatalLin] rename test class
    3b07f02d [FatalLin] rename for test
    b9ba5026 [FatalLin] update pom
    f09e2416 [FatalLin] debug
    e6a56a1e [FatalLin] fix
    af1f41ab [FatalLin] debug
    f88486a6 [FatalLin] execute test
    103ef87a [FatalLin] add codes for tracking report issue
---
 pom.xml                         | 9 ---------
 submarine-test/test-e2e/pom.xml | 9 +++++++++
 submarine-test/test-k8s/pom.xml | 9 +++++++++
 3 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/pom.xml b/pom.xml
index a6a55ca3..38671903 100644
--- a/pom.xml
+++ b/pom.xml
@@ -521,15 +521,6 @@
           </execution>
         </executions>
       </plugin>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-surefire-plugin</artifactId>
-        <version>2.22.2</version>
-        <configuration>
-          <forkMode>once</forkMode>
-          <argLine>-Dfile.encoding=UTF-8 ${argLine}</argLine>
-        </configuration>
-      </plugin>
     </plugins>
   </build>
 </project>
diff --git a/submarine-test/test-e2e/pom.xml b/submarine-test/test-e2e/pom.xml
index 5904dfde..8f14bb79 100644
--- a/submarine-test/test-e2e/pom.xml
+++ b/submarine-test/test-e2e/pom.xml
@@ -159,6 +159,15 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <version>2.22.2</version>
+        <configuration>
+          <forkMode>once</forkMode>
+          <argLine>-Dfile.encoding=UTF-8 ${argLine}</argLine>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 
diff --git a/submarine-test/test-k8s/pom.xml b/submarine-test/test-k8s/pom.xml
index 347b2b87..e5fefdad 100644
--- a/submarine-test/test-k8s/pom.xml
+++ b/submarine-test/test-k8s/pom.xml
@@ -147,6 +147,15 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-antrun-plugin</artifactId>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <version>2.22.2</version>
+        <configuration>
+          <forkMode>once</forkMode>
+          <argLine>-Dfile.encoding=UTF-8 ${argLine}</argLine>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org
For additional commands, e-mail: dev-h...@submarine.apache.org

Reply via email to