This is an automated email from the ASF dual-hosted git repository.
cdmikechen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new 3b274316 SUBMARINE-1389. restrict scipy < 1.11.0 for python 3.9 and
tensorflow 2.6
3b274316 is described below
commit 3b2743160c0310e8b8c3c00e92ee927e7f219100
Author: cdmikechen <[email protected]>
AuthorDate: Sat Jul 8 18:55:56 2023 +0800
SUBMARINE-1389. restrict scipy < 1.11.0 for python 3.9 and tensorflow 2.6
### What is this PR for?
From scipy 1.11.0 (https://github.com/scipy/scipy/releases/tag/v1.11.0),
scipy need numpy 1.21.6 or geater in python 3.9, so that tensorflow 2.6.5 CI
will not succeed.
Link:
https://github.com/apache/submarine/actions/runs/5486277299/jobs/9996172343
This is because in tensorflow 2.6.5 dependency list, the dependency version
of numpy is 1.19 (required: ~=1.19.2), so that we need restrict scipy < 1.11.0.
Also, we will remove support for python 3.7 and TensorFlow 2.6 in
subsequent releases (issue:
https://issues.apache.org/jira/browse/SUBMARINE-1391). The scipy restrictions
may be removed at that time.
### What type of PR is it?
Hot Fix
### Todos
* [x] - scipy < 1.11.0
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1389
### How should this be tested?
Python CI test
### Screenshots (if appropriate)
NA
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
Author: cdmikechen <[email protected]>
Signed-off-by: cdmikechen <[email protected]>
Closes #1082 from cdmikechen/SUBMARINE-1389 and squashes the following
commits:
c0fc99f6 [cdmikechen] fix length
348e19fa [cdmikechen] reformat
755e9afd [cdmikechen] restrict scipy < 1.11.0
---
submarine-sdk/pysubmarine/setup.py | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/submarine-sdk/pysubmarine/setup.py
b/submarine-sdk/pysubmarine/setup.py
index d66520c1..69320be6 100644
--- a/submarine-sdk/pysubmarine/setup.py
+++ b/submarine-sdk/pysubmarine/setup.py
@@ -59,6 +59,12 @@ setup(
# We are not upgrading this in submarine 0.8.0
for now,
# and will fix version compatibility issues in
0.8.1 or 0.9.0.
"typeguard<3.0.0",
+ # todo(cdmikechen): SUBMARINE-1389. From scipy 1.11.0
+ #
(https://github.com/scipy/scipy/releases/tag/v1.11.0),
+ # scipy need numpy 1.21.6 or geater in python
3.9.
+ # So that we need to restrict scipy < 1.11.0 to
support tf2.6.
+ # From submarine 0.8.1 or 0.9.0, we may no
longer support tensorflow 2.6
+ "scipy<1.11.0",
],
"pytorch": ["torch>=1.5.0", "torchvision>=0.6.0"],
},
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
