I'm seeing patch regression tests failures on trunk: CMD: svn patch /home/pm/sw/subversion/obj/subversion/tests/cmdline/svn-test-work/local_tmp/tmp3Grvg3 svn-test-work/working_copies/patch_tests-9 --dry-run --config-dir /home/pm/sw/subversion/obj/subversion/tests/cmdline/svn-test-work/local_tmp/config --password rayjandom --no-auth-cache --username jrandom <TIME = 0.085810> U svn-test-work/working_copies/patch_tests-9/A/mu > applied hunk @@ -1,6 +1,7 @@ with fuzz 1 > applied hunk @@ -7,6 +8,7 @@ with fuzz 2 > applied hunk @@ -19,6 +20,7 @@ with offset 1 and fuzz 140733193388034 CMD: svn patch /home/pm/sw/subversion/obj/subversion/tests/cmdline/svn-test-work/local_tmp/tmp3Grvg3 svn-test-work/working_copies/patch_tests-9 --config-dir /home/pm/sw/subversion/obj/subversion/tests/cmdline/svn-test-work/local_tmp/config --password rayjandom --no-auth-cache --username jrandom <TIME = 0.055382> U svn-test-work/working_copies/patch_tests-9/A/mu > applied hunk @@ -1,6 +1,7 @@ with fuzz 1 > applied hunk @@ -7,6 +8,7 @@ with fuzz 2 > applied hunk @@ -19,6 +20,7 @@ with offset 1 and fuzz 2 ============================================================= Outputs differ 'svn patch --dry-run' output: U svn-test-work/working_copies/patch_tests-9/A/mu > applied hunk @@ -1,6 +1,7 @@ with fuzz 1 > applied hunk @@ -7,6 +8,7 @@ with fuzz 2 > applied hunk @@ -19,6 +20,7 @@ with offset 1 and fuzz 140733193388034 'svn patch' output: U svn-test-work/working_copies/patch_tests-9/A/mu > applied hunk @@ -1,6 +1,7 @@ with fuzz 1 > applied hunk @@ -7,6 +8,7 @@ with fuzz 2 > applied hunk @@ -19,6 +20,7 @@ with offset 1 and fuzz 2 =============================================================
Note the silly fuzz values. Valgrind shows: $ valgrind -q ../../../subversion/svn/.libs/lt-svn patch x.patch svn-test-work/working_copies/patch_tests-9 U svn-test-work/working_copies/patch_tests-9/A/mu ==391== Conditional jump or move depends on uninitialised value(s) ==391== at 0x5DFA863: conv_10_quad (in /usr/lib/libapr-1.so.0.2.12) ==391== by 0x5DFB90F: apr_vformatter (in /usr/lib/libapr-1.so.0.2.12) ==391== by 0x5E08316: apr_pvsprintf (in /usr/lib/libapr-1.so.0.2.12) ==391== by 0x5978D23: svn_cmdline_printf (cmdline.c:275) ==391== by 0x41706D: notify (notify.c:364) ==391== by 0x4E798A6: maybe_send_patch_notification (patch.c:1023) ==391== by 0x4E7A6DE: apply_one_patch (patch.c:1308) ==391== by 0x4E7A90C: apply_patches (patch.c:1372) ==391== by 0x50D67F9: svn_wc__call_with_write_lock (lock.c:1863) ==391== by 0x4E7AA5B: svn_client_patch (patch.c:1403) ==391== by 0x418B1E: svn_cl__patch (patch-cmd.c:79) ==391== by 0x414A11: main (main.c:2234) > applied hunk @@ -1,6 +1,7 @@ with fuzz 1 > applied hunk @@ -7,6 +8,7 @@ with fuzz 2 > applied hunk @@ -19,6 +20,7 @@ with offset 1 and fuzz 2 With --dry-run there are also errors at notify.c:334: ==540== Conditional jump or move depends on uninitialised value(s) ==540== at 0x5DFA94A: conv_10_quad (in /usr/lib/libapr-1.so.0.2.12) ==540== by 0x5DFB90F: apr_vformatter (in /usr/lib/libapr-1.so.0.2.12) ==540== by 0x5E08316: apr_pvsprintf (in /usr/lib/libapr-1.so.0.2.12) ==540== by 0x5978D23: svn_cmdline_printf (cmdline.c:275) ==540== by 0x416F36: notify (notify.c:334) ==540== by 0x4E798A6: maybe_send_patch_notification (patch.c:1023) ==540== by 0x4E7A6DE: apply_one_patch (patch.c:1308) ==540== by 0x4E7A90C: apply_patches (patch.c:1372) ==540== by 0x50D67F9: svn_wc__call_with_write_lock (lock.c:1863) ==540== by 0x4E7AA5B: svn_client_patch (patch.c:1403) ==540== by 0x418B1E: svn_cl__patch (patch-cmd.c:79) ==540== by 0x414A11: main (main.c:2234) -- Philip
