On Tue, Feb 16, 2010 at 8:15 PM, Greg Stein <gst...@gmail.com> wrote: >>> Instead, we could not store size and mtime at all! :) >> >> Or we could store both to perform simple consistency checks... > > Dunno about that, but the storage of SIZE is part of the (intended) > algorithm for pristine storage. It is allowed to have a row in > PRISTINE with SIZE==0 in order to say "I know about this pristine, and > this row is present to satisfy integrity constraints with other > tables, but the pristine has NOT been written into the store." Once > the file *is* written, then the resulting size is stored into the > table.
Shouldn't the marker value to indicate "pristine has NOT been written into the store" be something like -1 instead of 0? Just taking into account that there might be files that really have a size of 0 bytes. These should be supported, shouldn't they? OTOH, I guess a 0 bytes pristine has to be handled specially anyway (what's the checksum of 0 bytes), no? Johan