On Mon, Mar 8, 2010 at 18:52, Bert Huijben <b...@qqmail.nl> wrote: >> -----Original Message----- >> From: Greg Stein [mailto:gst...@gmail.com] >> Sent: dinsdag 9 maart 2010 0:39 >> To: Greg Stein; dan...@elego.de; dev@subversion.apache.org >> Subject: Re: [PATCH] Replace entries in revision >> >> Looks pretty good! >> >> Several points: >> >> * use svn_wc__internal_text_modified_p(); then you won't need wc_ctx >> (just the db) >> * read_info can return NULL for the repos_* values >> * typo in analyze_status docstring (the typename) >> * status_deleted nodes have no revision info; you may simply want to >> test for SVN_INVALID_REVNUM, since read_info() will return that when >> it is "not interesting". IOW, it does the proper work for you >> * do you need wc_root? how about just using >> svn_wc__internal_path_switched() ? > > * You could optimize the checking for modifications to stop checking when > you find the first change. (You are not reporting specific changes)
An awesome side-effect of not using a status structure! Once modified, we don't need that data, yet the damned structure keeps filling it in... Good catch. Cheers, -g
