Hi Daniel,
Daniel Shahaf writes:
> > SVN_ERR(svn_stream_printf(stdout_stream, pool,
> > SVN_REPOS_DUMPFILE_REVISION_NUMBER
> > - ": %d\n", start_revision));
> > + ": %ld\n", start_revision));
> >
>
> Change is not in the log message. (strictly it isn't even a logical part of
> this commit, but I'm not going to be *that* pedantic...)
Sorry about the stray change.
> > + SVN_INT_ERR(svn_cmdline_fprintf(stderr, pool,
> > + _("UPPER refers to"
> > + "a non-existent revision.\n")));
>
> No newline in error messages (see HACKING).
Fixed.
> May want to say the revision number here? e.g.,
>
> "Revision %ld does not exist" % end_revision,
>
> because someone who isn't already deep in the code + usage message of svnrdump
> wouldn't know what UPPER is.
Fixed.
Thanks for the review.
-- Ram
