On Sun, Aug 01, 2010 at 03:50:49PM +0200, Bert Huijben wrote: > Yes, her you do, but before that there are a few SVN_ERR() statements that > can return WITHOUT wrapping the error. > > + SVN_ERR(svn_dirent_get_absolute(&src_abspath, src_path, > pool)); > + SVN_ERR(svn_dirent_get_absolute(&dst_abspath, dst_path, > pool)); > > So these two lines (from your original patch), leak the error if they return > an error message.
Ah, yeah. I see. What's the best way to handle this? Is simply assigning err to a temporary err2 variable safe? I would not expect so. Maybe instead of wrapping the error, we should just create a new one? Thanks, Stefan
