On Wednesday, August 11, 2010 12:10:41 pm C. Michael Pilato wrote:
> On 08/10/2010 09:22 PM, Alexey Neyman wrote:
> > Okay, try again:
> >
> > [[[
> > Fix the type of structures returned in bindings from
> > svn_fs_paths_changed2().
> >
> > * subversion/include/svn_fs.h
> >
> > (svn_fs_paths_changed2): Rename the argument from changed_paths_p to
> > changed_paths_p2, so that it's different from argument to
> > svn_fs_paths_changed().
>
> Minor nit -- I think 'changed_paths2_p' would be a better name. To me, a
> number at the very end of a parameter name says "differentiator" (as in
> 'strcmp(str1, str2)') whereas having that '2' closer to the 'changed_paths'
> name says "version iterator". But like I said, it's a minor nit.
>
> Otherwise, +1 on the patch.
Agreed. Updated patch attached.
Regards,
Alexey.
Index: subversion/bindings/swig/svn_fs.i
===================================================================
--- subversion/bindings/swig/svn_fs.i (revision 984278)
+++ subversion/bindings/swig/svn_fs.i (working copy)
@@ -62,6 +62,7 @@
%hash_argout_typemap(entries_p, svn_fs_dirent_t *)
%hash_argout_typemap(changed_paths_p, svn_fs_path_change_t *)
+%hash_argout_typemap(changed_paths2_p, svn_fs_path_change2_t *)
#ifndef SWIGPERL
%callback_typemap(svn_fs_get_locks_callback_t get_locks_func,
Index: subversion/include/svn_fs.h
===================================================================
--- subversion/include/svn_fs.h (revision 984278)
+++ subversion/include/svn_fs.h (working copy)
@@ -1154,7 +1154,7 @@
/** Determine what has changed under a @a root.
*
- * Allocate and return a hash @a *changed_paths_p containing descriptions
+ * Allocate and return a hash @a *changed_paths2_p containing descriptions
* of the paths changed under @a root. The hash is keyed with
* <tt>const char *</tt> paths, and has #svn_fs_path_change2_t * values.
*
@@ -1169,7 +1169,7 @@
* @since New in 1.6.
*/
svn_error_t *
-svn_fs_paths_changed2(apr_hash_t **changed_paths_p,
+svn_fs_paths_changed2(apr_hash_t **changed_paths2_p,
svn_fs_root_t *root,
apr_pool_t *pool);
