On Fri, Sep 03, 2010 at 08:58:09PM +0800, Wei-Yin Chen wrote: > Sorry, that line should have been > matching_filenames = [f for f in matching_filenames if not > os.path.islink(dirname+'/'+f)]
Hi, thanks for your patch! I think we should use os.sep instead of '/', because os.sep is more portable. Also, please put spaces around operators (a + b, instead of a+b), to keep the style of the script consistent. Thanks, Stefan > On Fri, Sep 3, 2010 at 8:15 PM, Wei-Yin Chen > <wyc...@video.ee.ntu.edu.tw>wrote: > > > This patch is for the following file. > > > > https://svn.apache.org/repos/asf/subversion/trunk/contrib/client-side/svn_apply_autoprops.py > > > > Log message: > > Do not apply autoprops on symbolic links in svn_apply_autoprops.py. > > > > > Index: svn_apply_autoprops.py > =================================================================== > --- svn_apply_autoprops.py > +++ svn_apply_autoprops.py > @@ -124,6 +124,7 @@ > prop_list = autoprops_line[1] > > matching_filenames = fnmatch.filter(filenames, fnmatch_str) > + matching_filenames = [f for f in matching_filenames if not > os.path.islink(dirname+'/'+f)] > if not matching_filenames: > continue >
