Hi Philip, [sorry about the delayed reply: I had a bad internet connection]
Philip Martin writes: > If we are going to use the APR atomic interface then the two reads > should use apr_atomic_read32. > > It would be better to use svn_atomic__init_once. It's a clear > indication that we are doing once only initialisation, so we don't > need all the comments, and it avoids any problems related to the size > of apr_fileperms_t. Also if enhancements are required (more memory > barriers say) then svn_atomic__init_once is the place to do it. Hm. I read up a little more about this, but what confuses me is- shouldn't the rest of the code already be needing this? Why are we re-thinking everything from scratch? -- Ram
