On 11/10/2010 05:21 AM, Julian Foad wrote: > I'm wondering about the wrapper function approach - did you feel it's > important to separate this error detection from the notification > function? I wonder if it would be simpler overall to get svn's existing > notifier code to track the presence of errors for you, instead.
I actually took this route first, only to find failure in various ways. Not
all functions use the generic notification system -- notably, *none* of them
use it if you pass --quiet. In the end , I used the paradigm employed by
"propdel" with the custom notification wrapper.
>> +/* Baton for use with svn_cl__check_externals_failed_notify_wrapper(). */
>> +struct svn_cl__check_externals_failed_notify_baton
>> +{
>> + void *wrapped_baton; /* The "real" notify_func2. */
>> + svn_wc_notify_func2_t wrapped_func; /* The "real" notify_func2 baton. */
>
> Those two are swapped relative to their comments.
Doh! Will fix.
--
C. Michael Pilato <[email protected]>
CollabNet <> www.collab.net <> Distributed Development On Demand
signature.asc
Description: OpenPGP digital signature
