>>> - SVN_ERR(normalize_string(&value, &was_normalized, pool));
>>> + SVN_ERR(normalize_string(&value, &was_normalized, eb->prop_encoding,
>>> + pool, pool));
>>> if (was_normalized)
>>> - (*(eb->normalized_node_props_counter))++;
>>> + (*(eb->le_normalized_node_props_counter))++;
>>> }
>>
>> This kind of code can be simplified (removing one level of indirection)
>> by making the baton hold the actual counter instead of a pointer to it.
>
> Okay.
Actually, I take that back. The pointer to the count comes from the
"public API" function svnsync_get_sync_editor(). I don't think that
this indirection can be removed without adding another API function to
retrieve the count. Something like:
int
svnsync_get_edit_baton_normalization_count(void *edit_baton)
{
return ((edit_baton_t*) edit_baton)->normalized_node_props_count;
}
Maybe this change can be done in another patch as the patch is getting
large again.