Hi Bert,
The problem was that my patch handled the expected error more
specifically and also failed to handle the svnserve case. That was wrong
on my part. I have tweaked the test case and attached a patch and log
message with this mail.
Please share your views on the same.
On Tuesday 08 February 2011 09:08 PM, Bert Huijben wrote:
This test XFails for the wrong reason on svn://.
EXPECTED STDERR (regexp):
svn: E175013: Unable to connect to a repository at URL
'svn://localhost/svn-test-work/repositories/authz_tests-20/A/mu'
svn: E175013: Access to '/svn-test-work\repositories\authz_tests-20/A/mu'
forbidden
svn: E175009: XML parsing failed: (403 Forbidden)
ACTUAL STDERR:
..\..\..\subversion\svn\cat-cmd.c:81: (apr_err=170001)
..\..\..\subversion\svn\util.c:967: (apr_err=170001)
..\..\..\subversion\libsvn_client\cat.c:233: (apr_err=170001)
..\..\..\subversion\libsvn_ra_svn\client.c:1557: (apr_err=170001)
..\..\..\subversion\libsvn_ra_svn\client.c:242: (apr_err=170001)
..\..\..\subversion\svnserve\serve.c:174: (apr_err=170001)
svn: E170001: Authorization failed
EXCEPTION: SVNUnmatchedError
See http://subversion.apache.org/buildbot/ or more specifically
http://ci.apache.org/builders/svn-slik-w2k3-x64-ra/builds/1675/steps/Test%20
fsfs%2Bsvn/logs/testlog
Bert
Thanks and regards
Prabhu
[[[
XFail testcase for the issue 3781
* subversion/tests/cmdline/authz_tests.py
(case_sensitive_authz): Now handles the svnserve errors too. Till now the expected error was more specific to the http protocol.
Patch by: Prabhu Gnana Sundar <prabhugs{_AT_}collab.net>
Reviewed by: Kamesh Jayachandran <kamesh{_AT_}collab.net>
]]]
Index: subversion/tests/cmdline/authz_tests.py
===================================================================
--- subversion/tests/cmdline/authz_tests.py (revision 1068769)
+++ subversion/tests/cmdline/authz_tests.py (working copy)
@@ -1107,12 +1107,12 @@
# error messages
expected_error_for_commit = "Commit failed"
- expected_error_for_cat = "svn: E175013: Unable to connect to a repository"+ \
- " at URL '" + mu_url + "'\n" + \
- "svn: E175013: Access to '/" + mu_repo_path + \
- "' forbidden\n" + \
- "svn: E175009: XML parsing failed: (403 Forbidden)"
+ if sbox.repo_url.startswith("http"):
+ expected_error_for_cat = ".*[Ff]orbidden.*"
+ else:
+ expected_error_for_cat = ".*svn: E170001: Authorization failed.*"
+
# test the case-sensitivity of the path inside the repo
write_authz_file(sbox, {"/": "jrandom = r",
"/A/mu": "jrandom =", "/a/Mu": "jrandom = rw"})
