Philip Martin wrote on Wed, Feb 16, 2011 at 11:09:14 +0000: > Daniel Shahaf <d...@daniel.shahaf.name> writes: > > > Philip, > > > > You vetoed the r962377 group since descend_into_replace() is XFail. > > > > I've un-xfailed that test in these commits: > > svn commit: r1063572 - in /subversion/trunk/subversion/tests/cmdline/ > > svn commit: r1063573 - /subversion/trunk/subversion/libsvn_repos/replay.c > > svn commit: r1063592 - > > /subversion/trunk/subversion/tests/cmdline/svnsync_tests.py > > > > Does your veto stand? > > My veto for r962377+r962378 was based on the test showing that the > implementation was not correct. Are you proposing to merge those 3 > revisions as well and make the test PASS? >
Yes. > -- > Philip
