Hi Daniel,

Daniel Shahaf writes:
> CC += artagnon
> 
> Ramkumar, I think the lesson from Mike and I's recent fixes is: "Mark
> unreachable code with a run-time assertion, not with a source comment".
> 
> i.e., if those places were marked with SVN__NOT_IMPLEMENTED(), debugging
> would have been easier.
> 
> (Tests pass if I add a SVN__NOT_IMPLEMENTED() to that function.)

Cool, thanks for pointing this out. Since this is such a common task,
maybe add this information to HACKING?

-- Ram

Reply via email to