On Mon, Feb 14, 2011 at 12:38 AM, Daniel Shahaf <d...@daniel.shahaf.name> wrote:
> Danny Trebbien wrote on Sun, Feb 13, 2011 at 20:20:45 -0800:
>> Attached are the corrected patch and log message. The new patch
>> incorporates this fix:
>> https://github.com/dtrebbien/subversion/commit/190f876b52626be6b30fe4e5a311c113fd87e589
>
> Is there a github link that shows the equivalent of 'svn log --diff' of
> this patch?  It's now about 700 lines, so having such a link would be
> very helpful to reviewers.
>
> Daniel

GitHub has a special "compare branches" URL, but you have to know the
SHA1 of two commits:  my latest non-merge commit and the last commit
of "upstream/trunk" that I merged into my master branch before that
commit.  Currently those are 190f876b52626be6b30fe4e5a311c113fd87e589
and c3e62d94c79a91176e2faab5bf6032bc070d5bc4, respectively (I
determined this with the `gitk` tool, which draws the commit DAG
[directed acyclic graph]).  The corresponding "compare" URL on GitHub
is:  
<https://github.com/dtrebbien/subversion/compare/c3e62d94c79a91176e2faab5bf6032bc070d5bc4...190f876b52626be6b30fe4e5a311c113fd87e589>.
 If you clone my git repo, then this roughly corresponds to the output
of `git diff c3e62d94c7...190f876b52`.

That lists all of my changes to my branch.  I'm not sure that it is
going to be helpful because I haven't maintained separate branches for
each of my proposed changes to Subversion trunk, so everything is kind
of mixed in.

Reply via email to