On 21.02.2011 11:20, Philip Martin wrote: > Noorul Islam K M <[email protected]> writes: > >> I think we have in consistent python indentation. I can see that we use >> 2 space in test/ and 4 in bindings/ctypes-python. Is it not a good idea >> to stick to common indentation? I can fix it. Fixing ctypes-python >> will be easier because it has less number of lines. >> >> Any thoughts? Or is it already known to everyone and decided to live >> with it. > I've never looked at the ctypes-python code, it is essentially a > separate code base from the test code. Do we ever cut-and-paste code > from one to the other? Do developers spend a lot of time switching > between them? If it really is separate then it's reasonable for it to > have its own style, and AFAIK 4 spaces is the more common style in the > Python world.
It is -- but our hacking guide (used to?) require 2-space indent for Python, which is why the makefile generators and the test suite use that. -- Brane
