On 21.02.2011 11:32, Noorul Islam K M wrote: > Noorul Islam K M <noo...@collab.net> writes: > >> Stefan Sperling <s...@elego.ed> writes: >> >>> On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: >>> >>>> This patch reduces checkout by around 23 times. >>> On my system the difference is 43 seconds vs. 30 seconds. >>> >>> We lose the ability to easily spot which of the subtest is failing >>> if we do this. I.e. instead of: >>> >>> ... >>> PASS: input_validation_tests.py 19: non-working copy paths for 'status' >>> FAIL: input_validation_tests.py 20: non-working copy paths for 'patch' >>> PASS: input_validation_tests.py 21: non-working copy paths for 'switch' >>> ... >>> >>> all we'd get is: >>> >>> FAIL: input_validation_tests.py 1: inavlid wc and url targets >>> >>> Is there a way of keeping these as individual tests but also >>> avoiding the overhead of creating a repository and a working copy? >>> If there isn't I would prefer to just leave this as it is now because >>> I prefer the current output. >> I think it will be possible by keeping sandbox global. I will modify and >> send an updated patch. >> > I looked into it. I don't think it is straight forward. I will leave it > as such. As you said 13 seconds gain is no big deal.
Given that the one commandment for writing test cases is to make them independent of each other, I can hardly see how you could keep a global sandbox. The most important "optimization" for tests is to make them more reliable, testcase performance comes third on the list at best (after comprehensive). -- Brane
