> -----Original Message----- > From: Philip Martin [mailto:philip.mar...@wandisco.com] > Sent: maandag 4 april 2011 17:37 > To: dev@subversion.apache.org > Subject: notification backward compatibilty of the testsuite > > I've been working on a revert implementation that fixes some correctness > problems. A side effect of this change is that the notifications > change. In 1.6 revert only notifies for the root of an added tree, my > new code notifies for all the added nodes. This causes 3 of the > regression tests to fail. The 1.6 behaviour seems a bit arbitrary to > me, and reproducing it with my new code would be difficult. > > Do we need any sort of backward compatibility in the testsuite? Is it > acceptable to simply change the regression tests to expect the new > notifications? Something like this:
I don't think we promise notifications to stay the same over versions and as an application developer I prefer a bit more notifications. There are several other places where we already changed notifications a few times (merge, tree conflicts, etc. etc.) +1 from me on just adding the extra notifications. (I would have a problem if we removed notification calls for specific paths; but not if they were just filtered in svn's output) Bert