On May 7, 2011 10:18 PM, "Hyrum K Wright" <[email protected]> wrote: > > On Sat, May 7, 2011 at 1:26 AM, <[email protected]> wrote: > > Author: gstein > > Date: Sat May 7 06:26:54 2011 > > New Revision: 1100460 > > > > URL: http://svn.apache.org/viewvc?rev=1100460&view=rev > > Log: > > Simplify some tree conflict code by removing an (unused) error return. > > ...and add a bunch of vertical whitespace. :) > > (I thought you were the guy who advocated separating whitespace and > functional changes into separate commits. :P )
... when those whitespace changes hide functional changes, yes. For example, indents. You can't see functional changes within a 20-line block of indent change. I added some blank lines, but those did not affect the reviewability, nor was it a significant change to the whitespace, column wrapping, or other non-functional style. And in this case, I didn't feel the blank lines reached a level of significance to merit a mention. In short: fully-considered :-) Cheers, -g
