On Sun, 2011-05-15, stef...@apache.org wrote:
> Don't give the impression that init_txn_callbacks might fail.
> 
> * subversion/libsvn_fs_fs/caching.c
>   (init_txn_callbacks): void is the appropriate return type.

> Modified: subversion/trunk/subversion/libsvn_fs_fs/caching.c
> ==============================================================================
>  
> -static svn_error_t *
> +static void

Hi Stefan.  Please could you give this function a doc string, and
init_callbacks() later in the same file.  Thanks.

- Julian


>  init_txn_callbacks(svn_cache__t **cache,
>                     apr_pool_t *pool)
>  {
> @@ -373,8 +373,6 @@ init_txn_callbacks(svn_cache__t **cache,
>                                  remove_txn_cache,
>                                  apr_pool_cleanup_null);
>      }
> -
> -  return SVN_NO_ERROR;
>  }


Reply via email to