Hi,

I checked the sourcecode of subversion (r1140736) with cppcheck. Please have a look on the result file in the attachement.
[SVN\subversion\bindings\javahl\native\JNIThreadData.cpp:40]: (warning)
Member variable 'JNIThreadData::m_formatBuffer' is not initialized in the
constructor.
[SVN\subversion\bindings\javahl\native\JNIUtil.h:41] ->
[SVN\subversion\include\svn_types.h:132]: (style) Struct 'svn_error_t'
forward declaration unnecessary, already declared
[SVN\subversion\bindings\javahl\native\RevpropTable.cpp:46]: (performance)
Possible inefficient checking for 'm_revprops' emptiness.
[SVN\subversion\bindings\javahl\native\Targets.h:35] ->
[SVN\subversion\include\svn_types.h:132]: (style) Struct 'svn_error_t'
forward declaration unnecessary, already declared
[SVN\subversion\libsvn_auth_kwallet\kwallet.cpp:203]: (style) Variable 'app'
is assigned a value that is never used
[SVN\subversion\libsvn_auth_kwallet\kwallet.cpp:273]: (style) Variable 'app'
is assigned a value that is never used
[SVN\subversion\libsvn_client\delete.c:368]: (information) The scope of the
variable 'i' can be reduced
[SVN\subversion\libsvn_client\merge.c:6108]: (information) The scope of the
variable 'oldest_changed_rev' can be reduced
[SVN\subversion\libsvn_client\merge.c:6108]: (information) The scope of the
variable 'youngest_changed_rev' can be reduced
[SVN\subversion\libsvn_client\merge.c:8220]: (information) The scope of the
variable 'end_rev' can be reduced
[SVN\subversion\libsvn_delta\xdelta.c:259]: (style) Clarify calculation
precedence for - and ?
[SVN\subversion\libsvn_diff\diff.c:71]: (style) Variable 'diff' is not
assigned a value
[SVN\subversion\libsvn_diff\token.c:158]: (style) Variable 'start_position'
is not assigned a value
[SVN\subversion\include\private\svn_temp_serializer.h:42] ->
[SVN\subversion\include\svn_string.h:120]: (style) Struct 'svn_stringbuf_t'
forward declaration unnecessary, already declared
[SVN\subversion\libsvn_fs_fs\tree.c:3108]: (information) The scope of the
variable 'retry' can be reduced
[SVN\subversion\libsvn_ra_neon\session.c:454]: (style) Variable
'http_auth_types' is assigned a value that is never used
[SVN\subversion\libsvn_repos\dump.c:710]: (error) Possible null pointer
dereference: pb - otherwise it is redundant to check if pb is null at line
717
[SVN\subversion\libsvn_repos\dump.c:808]: (error) Possible null pointer
dereference: pb - otherwise it is redundant to check if pb is null at line
814
[SVN\subversion\libsvn_subr\mergeinfo.c:374]: (information) The scope of the
variable 'tmp_revnum' can be reduced
[SVN\subversion\libsvn_subr\simple_providers.c:164]: (information) The scope
of the variable 'have_passtype' can be reduced
[SVN\subversion\libsvn_wc\adm_ops.c:1292]: (style) Variable 'special' is
assigned a value that is never used
[SVN\subversion\libsvn_wc\adm_ops.c:1388]: (style) Variable 'special_prop'
is assigned a value that is never used
[SVN\subversion\libsvn_wc\adm_ops.c:852]: (information) The scope of the
variable 'exists' can be reduced
[SVN\subversion\libsvn_wc\wc_db.c:8438]: (style) struct or union member
'update_baton_t::new_changed_rev' is never used
[SVN\subversion\svnrdump\dump_editor.c:498]: (error) Possible null pointer
dereference: pb - otherwise it is redundant to check if pb is null at line
490
[SVN\subversion\svnrdump\dump_editor.c:610]: (error) Possible null pointer
dereference: pb - otherwise it is redundant to check if pb is null at line
601
[SVN\subversion\tests\libsvn_fs_base\fs-base-test.c:1093]: (style) struct or
union member 'node_created_rev_args::rev' is never used
[SVN\subversion\tests\libsvn_fs_base\fs-base-test.c:1158]: (information) The
scope of the variable 'i' can be reduced

Reply via email to