C. Michael Pilato wrote on Thu, Jul 07, 2011 at 16:54:46 -0400:
> On 07/07/2011 04:50 PM, Daniel Shahaf wrote:
> > Hmm.  For wc we have upgrade tests using tarred old working copies.
> > Perhaps we should do the same for svnadmin/fsfs?
> > 
> > % grep upgrade svnadmin_tests.py | wc -l
> > 0
> 
> We haven't tested upgrades of filesystems in the past because we thus far
> haven't allowed 'svnadmin upgrade' to do anything substantial.  Typically,
> it just plops a new integer into the 'format' file.  There was some minor

We don't test 'svnadmin pack' either.

> file reorg in the FSFS side a while ago, but again, nothing really major.
> And that's intentional:  we want upgrade to be a constant-time operation,

Then why does 'svnadmin upgrade' say

% $svnadmin upgrade r3 
Repository lock acquired.
Please wait; upgrading the repository may take some time...

?

> leaving more costly upgrades to the likes of a parallel dump/load.
> 
> -- 
> C. Michael Pilato <[email protected]>
> CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
> 


Reply via email to