On Thu, Jul 21, 2011 at 5:04 PM, Greg Stein <gst...@gmail.com> wrote: > On Thu, Jul 21, 2011 at 11:37, <pbu...@apache.org> wrote: >>... >> +++ subversion/trunk/subversion/libsvn_client/merge.c Thu Jul 21 15:37:21 >> 2011 >>... >> @@ -8155,8 +8163,8 @@ remove_noop_subtree_ranges(const char *u >> >> APR_ARRAY_PUSH(log_targets, const char *) = ""; >> >> - SVN_ERR(svn_ra_get_log2(ra_session, log_targets, youngest_gap_rev->end, >> - oldest_gap_rev->start + 1, 0, TRUE, TRUE, FALSE, >> + SVN_ERR(svn_ra_get_log2(ra_session, log_targets, oldest_gap_rev->start + >> 1, >> + youngest_gap_rev->end, 0, TRUE, TRUE, FALSE, >> apr_array_make(scratch_pool, 0, >> sizeof(const char *)), >> log_noop_revs, &log_gap_baton, scratch_pool)); > > Given the sensitivity of the overall algorithm to ordering, I think > that call deserves an explanatory comment about why the logs are > ordered that way.
Quite right. Done r1149626. Paul > Cheers, > -g >
