Jonathan Nieder wrote on Sat, Nov 05, 2011 at 22:57:55 -0500: > Greg Stein wrote: > > On Nov 5, 2011 6:06 AM, "Philip Martin" <philip.mar...@wandisco.com> wrote: > > >> We have a mkdir-init target in the Makefile that is supposed to create > >> the build directories. > > > > Right. It creates what is needed rather than a scattershot hope. > > Thanks for the pointer. Running "make mkdir-init" works fine. > > > Jonathan: can you adjust mkdir-init to include *just* the directories > > necessary, that you've found through your new test? > > It seems that the patch should look like this, then: > > [[[ > Allow "make extraclean-swig" and "make swig-pl" in VPATH builds without > requiring the user to run "make mkdir-init" by hand first. > > * Makefile.in > (external-all, external-install): Depend on mkdir-init. > ($(SWIG_PL_DIR)/native/Makefile.PL): Likewise. > (swig-pl): Likewise. > ($(SWIG_PY_DIR)/libsvn): Likewise. > > (external-clean, external-distclean): Check if directories exist > before cleaning them. > (external-extraclean): Likewise. > (schema-clean): Likewise. > (clean-swig-py): Likewise. > (clean-swig-rb): Likewise. > ]]] > > Index: Makefile.in > =================================================================== > --- Makefile.in (revision 1198126) > +++ Makefile.in (working copy) > @@ -557,7 +557,7 @@ mkdir-init: > done > > # recursive targets to handle external projects (e.g. APR, Neon) > -external-all external-install: > +external-all external-install: mkdir-init > @target=`echo $@ | sed s/external-//`; \ > list='$(SVN_EXTERNAL_PROJECT_SUBDIRS)'; \ > for i in $$list; do \
What is this hunk needed for? mkdir creates ./doc and ./subversion/**/, why does the make target that recurses into apr/neon/etc need to create those dirs?
