On Thursday, November 17, 2011 11:05 AM, "Philip Martin" <philip.mar...@wandisco.com> wrote: > Daniel Shahaf <d...@daniel.shahaf.name> writes: > > > I suggested on IRC to make the code record the complete error chain. > > Would we do that in the logging handlers in mod_dav_svn and svnserve, > and thus do it for every error that is logged? Or would we get the > calling code in libsvn_fs_fs to invoke the logging handler multiple > times?
I had in mind the former. I don't see why we would ever want to invoke fs->warning_func() multiple times; it seems sufficient for me to invoke it once, with the complete error chain, and let the callback implementation handle the chain, or parts thereof, as it sees fit. > > -- > uberSVN: Apache Subversion Made Easy > http://www.uberSVN.com >
