On Dec 19, 2011, at 20:36 , Eric S. Raymond wrote: > I want to get it finished and into the repo, where it will answer > support questions so you don't have to. This is the 0.3 version; please > note the open questions listed near the beginning.
[[[ Open questions: 1. Is replace on a nonexistent path expected to fail? 2. Is add on an existing path expected to fail? ]]] Hi Eric, Yes, and yes. I'm not an expert server-side hacker, but it'd be a cryin' shame if either of those operations was allowed. The server code is supposed to error out on any conflict, as explained in the comment to svn_fs_commit_txn(): http://subversion.apache.org/docs/api/1.6/group__svn__fs__txns.html#gae86163e9e3623168cee620446a40e755 For a reality check, I tried some very simple surgeries on a valid dumpfile, and loaded it into an empty repository. 1. Replacing a non-existent path is rejected with "E160013: File not found". 2. Adding path that already exists succeeds in at least one case. :-( - Adding a directory twice fails with "E160020: File already exists". - Adding a (fresh) file twice fails with "E160004: Invalid change ordering: new node revision ID without delete". - Adding a file with history twice in the same revision fails with "E160004: Invalid change ordering: new node revision ID without delete". - Adding a file with history twice _in two revisions_ succeeds silently (!) Looks like our sanity-checking of 'svnadmin load' input needs some work. Cheers, Steve -- Stephen Butler | Senior Consultant elego Software Solutions GmbH Gustav-Meyer-Allee 25 | 13355 Berlin | Germany tel: +49 30 2345 8696 | mobile: +49 163 25 45 015 fax: +49 30 2345 8695 | http://www.elegosoft.com Geschäftsführer: Olaf Wagner | Sitz der Gesellschaft: Berlin Amtsgericht Charlottenburg HRB 77719 | USt-IdNr: DE163214194
