Philip Martin <[email protected]> writes: > Vincent Batts <[email protected]> writes: > >> On 19/12/11 10:04 +0200, Daniel Shahaf wrote: >>>Please send separate patches for separate functional changes. Getting >>>the tests to pass with ruby1.8 would be a separate functional change than >>>supporting ruby1.9. >> >> Okay after a bit of familiarizing myself with the svn library, attached >> are two patches. One that is a patch to accomodate the ruby bindings for >> 1.8 and 1.9 (svn-ruby-1.9-fixes.patch). >> The other is an update to the unit tests, to catch ruby 1.9 >> up to speed, while not breaking the tests for ruby 1.8 >> (svn-update-ruby-tests.patch) >> All tests pass ruby 1.8, like they have, and all but 1 pass on ruby >> 1.9.3. The one test that is failing is in time_delta.rb, and is due to >> the overhaul of encoding that happened for ruby 1.9. I would welcome >> someone investigating this encoding challenge too. But otherwise things >> look pretty good to support ruby 1.9 now. > > I think you have names of two patches switched, but never mind. When I > try to use ruby 1.9.1 the tests fail: > > make check-swig-rb > cd /home/pm/sw/subversion/obj2/subversion/bindings/swig/ruby; \ > if [ "1" -eq 1 -a "9" -lt 9 ] ; then \ > /usr/bin/ruby1.9.1 -I > /home/pm/sw/subversion/obj2/../src2/subversion/bindings/swig/ruby \ > > /home/pm/sw/subversion/obj2/../src2/subversion/bindings/swig/ruby/test/run-test.rb > \ > --verbose=normal; \ > else \ > /usr/bin/ruby1.9.1 -I > /home/pm/sw/subversion/obj2/../src2/subversion/bindings/swig/ruby \ > > /home/pm/sw/subversion/obj2/../src2/subversion/bindings/swig/ruby/test/run-test.rb; > \ > fi > <internal:lib/rubygems/custom_require>:29:in `require': no such file to load > -- test/unit/ui/testrunnermediator (LoadError) > from <internal:lib/rubygems/custom_require>:29:in `require' > from > /home/pm/sw/subversion/src2/subversion/bindings/swig/ruby/test/test-unit-ext/always-show-result.rb:20:in > `<top (required)>' > from <internal:lib/rubygems/custom_require>:29:in `require' > from <internal:lib/rubygems/custom_require>:29:in `require' > from > /home/pm/sw/subversion/src2/subversion/bindings/swig/ruby/test/test-unit-ext.rb:20:in > `<top (required)>' > from <internal:lib/rubygems/custom_require>:29:in `require' > from <internal:lib/rubygems/custom_require>:29:in `require' > from > /home/pm/sw/subversion/obj2/../src2/subversion/bindings/swig/ruby/test/run-test.rb:38:in > `<main>' > make: *** [check-swig-rb] Error 1
Is this because only 1.9.1 is not supported and I need 1.9.3? Both configure and 'make swig-rb' appear to work but 'make check-swig-rb' fails. -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com
