Hi Daniel,
On Sun, Apr 8, 2012 at 2:30 PM, Daniel Shahaf <danie...@elego.de> wrote:
> joeswat...@apache.org wrote on Fri, Apr 06, 2012 at 18:28:30 -0000:
>> Author: joeswatosh
>> Date: Fri Apr 6 18:28:30 2012
>> New Revision: 1310535
>>
>> def test_changelists_get_without_block
>> assert_changelists do |ctx, changelist_name|
>> - ctx.changelists(changelist_name, @wc_path)
>> + changelists = ctx.changelists(changelist_name, @wc_path)
>> + changelists.each_value { |v| v.sort! }
>> + changelists
>
> Do you need to sort CHANGELISTS, or only the values therein?
>
In this case only the values, as the changelists object is itself a
Ruby (not APR) hash, so the order of hash values is determined by the
Object#hash function.
> Don't this and your other recent commit need to be backported to 1.7.x?
>
Possibly. Obviously neither commit impacts the bindings themselves,
but if we are supporting the latest APR in the 1.7 branch, it will
easier to have the tests passing than to have to explain why they
aren't. What do you think?
Thanks for checking up on me.
--
Joe
>> end
>> end
>>
>>
